Skip to content

[Tests] Cleanup PulsarClient instances - #10197

Merged
merlimat merged 4 commits into
apache:masterfrom
lhotari:lh-cleanup-pulsarclient-instances
Apr 15, 2021
Merged

[Tests] Cleanup PulsarClient instances#10197
merlimat merged 4 commits into
apache:masterfrom
lhotari:lh-cleanup-pulsarclient-instances

Conversation

@lhotari

@lhotari lhotari commented Apr 12, 2021

Copy link
Copy Markdown
Member

Motivation

Pulsar tests currently leak a lot of PulsarClient instances

Modifications

  • consistently add cleanup for all PulsarClient instances created in tests
  • prefer using Lombok's @Cleanup for handling cleanup
  • in the case of replacing a previous PulsarClient instance, close the previous instance before replacement.

@merlimat merlimat added this to the 2.8.0 milestone Apr 12, 2021
@lhotari
lhotari force-pushed the lh-cleanup-pulsarclient-instances branch 2 times, most recently from d8a2c4e to 82c1bfc Compare April 13, 2021 10:41
@lhotari
lhotari force-pushed the lh-cleanup-pulsarclient-instances branch 2 times, most recently from a0969bb to a4dbd3a Compare April 15, 2021 07:55
@lhotari

lhotari commented Apr 15, 2021

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

2 similar comments
@lhotari

lhotari commented Apr 15, 2021

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@lhotari

lhotari commented Apr 15, 2021

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@lhotari

lhotari commented Apr 15, 2021

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@lhotari
lhotari force-pushed the lh-cleanup-pulsarclient-instances branch from a4dbd3a to fbccc7b Compare April 15, 2021 14:03
@merlimat
merlimat merged commit 7c0a798 into apache:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants